Re: svn commit: rev 6139 - trunk/tools/cvs2svn

Greg Stein <gstein@lyra.org> writes:
> > (main): Init trackers here, as part of the operation ctx, and
> > close them when done.
>
> Do they actually need to be closed? Once the refcount hits zero,
> they'll get closed. And is it important to actually remove them?

Hmmm. If the usual Python idiom is to depend on the refcount to close
objects like this, then that's fine with me. I just have some trouble
getting used to it, but I'll get over it :-).

> I'll also note that the operation context is growing into a mass of global
> variables :-). It was initially introduced as an easy way to pass a glom of
> options from the cmdline into the main processing. Somewhere it morphed into
> holding some state, which can be dangerous. One reason to minimize passing
> 'ctx' around -- it makes it easier to see what state is being used and
> passed (which I saw you do w.r.t ctx.prune, so Goodness).

Yah, good point! I'll take a look at it, thanks.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 5 16:57:47 2003