Re: svn commit: rev 6139 - trunk/tools/cvs2svn

On Tue, Jun 03, 2003 at 04:01:49PM -0500, kfogel@tigris.org wrote:
>...
> (main): Init trackers here, as part of the operation ctx, and
> close them when done.

Do they actually need to be closed? Once the refcount hits zero, they'll get
closed. And is it important to actually remove them?

I'll also note that the operation context is growing into a mass of global
variables :-). It was initially introduced as an easy way to pass a glom of
options from the cmdline into the main processing. Somewhere it morphed into
holding some state, which can be dangerous. One reason to minimize passing
'ctx' around -- it makes it easier to see what state is being used and
passed (which I saw you do w.r.t ctx.prune, so Goodness).

>...
> + def close(self):
> + self.open_db.close()
> + self.bound_db.close()
> + os.remove(self.open_db_file)
> + os.remove(self.bound_db_file)

I'm not sure on the need here...

>...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org