[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: dav memory scalability

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-05-30 18:47:35 CEST

Brandon Ehle <azverkan@yahoo.com> writes:

> 1) Inside dav_method_propfind(), two different headers could possibly
> be sent depending on whether the ctx.propstat_404 bit gets set.
> [...]
> 2) dav_send_multistatus() needs to know which "xmlns:" attributes need
> to be set in the <D:multistatus> tag. This would require making
> resource->hooks->walk() a two step process. The first step would be
> required just to ask the provider for the namespaces that need to be
> added to the multistatus tag. Then you could send the header and run
> resource->hooks->walk() to stream the data.

It sounds like there's exactly one problem... dav_send_multistatus()
optionally takes a list of namespaces to put in the <mulitstatus> tag,
and those namespaces may exist/vary based on the results of the walk.

Hmmm, maybe it's not necessary to worry about this at all. Why not
just unconditionally add the extra doc->namespaces to the
<multistatus> tag? Why is this code *only* doing so if a 404 came up
within the walk? Does it hurt to always mention them? Would it be
wrong?

Or... maybe somehow doc->namespaces gets modified during the walk? It
which case, yeah, we'd need to harvest all namespaces first, before
doing the "real" walk.

Let me investigate...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 31 00:15:09 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.