[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: small user request: confirm before commit

From: Faheem Mitha <faheem_at_email.unc.edu>
Date: 2003-05-27 22:39:52 CEST

On 27 May 2003 14:59:03 -0500, Ben Collins-Sussman <sussman@collab.net> wrote:
> Faheem Mitha <faheem@email.unc.edu> writes:
>> However, would it not be better to not commit the change if you
>> realise while you are writing the log message in the editor (say)
>> that you don't want to commit?
> Then quit the editor abnormally without saving changes; svn gives you
> a chance to abort the commit. Someone just pointed that out.


>> Let me just ask, what is the downside to my suggestion? As I said
>> already, this could be made a configurable option, so experts and such
>> who don't want to bother with it don't have to.
> Greg Hudson sent a mail over the weekend that very eloquently
> explained that there's no such thing as "just another option". Adding
> options is expensive, especially in terms of supporting and
> debugging. That's the downside.

Fair enough. I have no training as a software developer, so I'm not
fully aware of these issues.
> Furthermore, I agree with Florin's comment: if 'svn commit' always
> requires that you type "y, enter", then users simply habituate to
> that. The entire key sequence becomes a single "action" after a short
> time. So I don't believe this behavior will be effective in
> preventing accidental commits.

I believe the "quit editor abnormally without saving changes" option
takes care of my concern. Though, as I said elsewhere, it would be
nice if it was documented somewhere.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 27 22:44:37 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.