Re: small user request: confirm before commit

On Tue, May 27, 2003 at 02:59:03PM -0500, Ben Collins-Sussman wrote:
> Faheem Mitha <faheem@email.unc.edu> writes:
>
> > However, would it not be better to not commit the change if you
> > realise while you are writing the log message in the editor (say)
> > that you don't want to commit?
>
> Then quit the editor abnormally without saving changes; svn gives you
> a chance to abort the commit. Someone just pointed that out.

Unfortunately I have a habit of saving often. If you start writing the
message and save before continuing, you might forget you have saved and
just exit the editor, thinking it will abort the commit. Of course it's
still possible to commit a reverse changeset and patch up the log
message, though. I wouldn't want Subversion to ask every time you've
exited your editor if you really want to commit. I'm also not sure this
should be an option.

> > Let me just ask, what is the downside to my suggestion? As I said
> > already, this could be made a configurable option, so experts and such
> > who don't want to bother with it don't have to.
>
> Greg Hudson sent a mail over the weekend that very eloquently
> explained that there's no such thing as "just another option". Adding
> options is expensive, especially in terms of supporting and
> debugging. That's the downside.

Havoc Pennington has also written about this:

http://www106.pair.com/rhp/free-software-ui.html

See the "The Question of Preferences" section.

-- 
Michael Wood <mwood@its.uct.ac.za>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org