[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: Make apply_textdelta unconditional

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-05-27 17:53:48 CEST

On Tue, 2003-05-27 at 11:18, cmpilato@collab.net wrote:
> By "unconditional", I trust you mean only "not conditioned on the
> presence or absence of a 'text_deltas' parameter." We still only want
> to call apply_textdelta when we figure out that there are deltas to
> send. Agreed?

Whoops, should have been much clearer.

I'm proposing to remove this paragraph from the editor interface
apply_txdelta interface:

   * If @a *handler is set to @c NULL, then the editor is indicating to
   * the driver that it is not interested in receiving information about
   * the changes in this file. The driver can use this information to
   * avoid computing changes. Note that the editor knows the change
   * has occurred (by virtue of this function being invoked), but is
   * simply indicating that it doesn't want the details.

I would change all editors to provide window handlers, and all drivers
to send windows without first checking whether handler is NULL. (Status
editors and the mod_dav_svn editors would just ignore the windows.) The
driver knows, based on out-of-band information, whether to provide empty
or full deltas and whether to provide checksums.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 27 17:54:45 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.