[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: Make apply_textdelta unconditional

From: <cmpilato_at_collab.net>
Date: 2003-05-27 17:18:55 CEST

Greg Hudson <ghudson@MIT.EDU> writes:

> I've gone around on the apply_textdelta vs. dir_deltas text parameters
> issue, and now I think the right answer to this redundancy is to make
> apply_textdelta unconditional. (A "status" operation would still
> forge an empty delta, just as it does now if the editor requests text
> deltas.) The reasons:

By "unconditional", I trust you mean only "not conditioned on the
presence or absence of a 'text_deltas' parameter." We still only want
to call apply_textdelta when we figure out that there are deltas to
send. Agreed?

> As an aside, libsvn_fs/tree.c:txn_body_is_different has the following
> comment:
> /* ### todo: Finish svn_fs__things_different to do the full content
> comparison it was intended to do. */
> If anyone ever implemented this todo, it would force a "status"
> operation to bear the cost of examining the old and new content of
> each potentially changed file. However, now that we have checksums,
> we ought to be able to do a checksum comparison instead.

Oooh. That would be cool (and so much cheaper).

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 27 17:19:27 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.