[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5996 - trunk/subversion/libsvn_client

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-05-21 04:04:13 CEST

On Tuesday, May 20, 2003, at 09:50 PM, Greg Stein wrote:

> On Tue, May 20, 2003 at 01:26:57PM -0500, cmpilato@tigris.org wrote:
>> ...
>> (apply_textdelta): Use the file baton's pool to store the tmpfile
>> and its path.
> How about: keep the file in the handler pool, and rely on that to auto
> close
> the file when the handler is done. Then strdup the path into the file
> baton.
> You'd eliminate the need to store the pool in the baton (as that pool
> sitting there could lead to Badness).

The original reason the file was moved to the baton was so we could
explicitly close it (flushing data to disk) before doing a
copy-and-translate. If you move it to any pool, be sure that the
auto-close happens before that occurs.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 21 04:05:07 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.