[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5996 - trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-05-21 03:50:55 CEST

On Tue, May 20, 2003 at 01:26:57PM -0500, cmpilato@tigris.org wrote:
> (apply_textdelta): Use the file baton's pool to store the tmpfile
> and its path.

How about: keep the file in the handler pool, and rely on that to auto close
the file when the handler is done. Then strdup the path into the file baton.
You'd eliminate the need to store the pool in the baton (as that pool
sitting there could lead to Badness).

> + /* Was a txdelta even sent? */
> + if (! fb->tmppath)
> + return SVN_NO_ERROR;

This case isn't ever supposed to happen, right? We should be getting text
for every file added... ? The 'if' statement kind of creates a false sense
of "this might happen"


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 21 03:48:44 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.