[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Issue 390 "Need feedback level arguments for cmdline client and libs."

From: Michael Fletcher <mike.fletcher_at_theplanet.ca>
Date: 2003-05-19 20:48:13 CEST


My name is Michael Fletcher. Part of my day-to-day work is
administrating a commercial SCM tool -- CCC/Harvest. Harvest has some
shortcoming and what better way to vent my frustration that to work on
its future replacement :).

I thought I would like to start with one of those 'bite-sized' issues
and I picked up #390. I may also pick up #783 (Notification System for
Properties). They are somewhat related.

Before I start submitting patches I have a couple of questions. Please
be gentle, i am new.

- When you run 'svn cp' from your working copy to another place in your
working copy why is there no output. Should it say 'A
branches/newbranch' or something like that.

- Where should I hook up tracing for --verbose? To me this seems like
a large change all over the place. Am I missing something?

- I thought I would only call svn_cl__get_notifier once in main.c and
remove the svn_cl__get_notifier calls from *-cmd.c. I then would pass
quiet and verbose in the notify_baton.

* subversion/clients/cmdline/*-cmd.c
   Removed numerous calls to svn_cl__get_notifier.

* subversion/clients/cmdline/main.c
   Added one call svn_cl__get_notifier.

* subversion/clients/cmdline/cl.h
   Added is_verbose and is_quiet arguments.

* subversion/clients/cmdline/feedback.c
   (notify_baton) Added quiet and verbose.
   (notify) Use baton to determin if statements should be printed or not.
   (svn_cl__get_notifier) Used new is_verbose and is_quiet arguments to
   notify_baton quiet and verbose.

* subversion/clients/cmdline/copy-cmd.c
   !!! This requires some extra work.

Michael Fletcher

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 19 20:51:46 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.