[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1296: --force option for svn export

From: <cmpilato_at_collab.net>
Date: 2003-05-19 06:14:05 CEST

plasma <plasmaball@pchome.com.tw> writes:

> LOG:
>
> Fix issue #1296: --force option for svn export
>
> * clients/cmdline/main.c: Add svn_cl__force_opt for export in
> svn_cl__options.
>
> * clients/cmdline/export-cmd.c, include/svn_client.h:
> Interface of svn_client_export() is changed. A new argument named force.
>
> * libsvn_clients/export.c
> (svn_client_export, svn_client__get_export_editor):
> Interface is changed. A new argument named force.
> (struct edit_baton): A new force field is added.
> (open_root, add_directory): If a --force option is specified, an
> existing directory is no longer an error.

Just a suggestion (doesn't count as a patch review): if an existing
directory is the only condition that causes SVN_ERR_WC_OBSTRUCTED_UPDATE
to be returned as part of an export, you might consider having the
client code (in export-cmd.c) check for that error, and wrap it with a
suggestion that the user either remove the directory, or use the
--force option.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 19 06:19:02 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.