[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suspect bug in Windows cmd line client - multiple prompt

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-05-16 22:12:42 CEST

Werner Schiendl wrote:

>Hi,
>
>I found what I believe is a bug in the Windows version of the subversion
>command line client (svn.exe) version 0.22.2 from the binary installer:
>
>When being prompted whether to trust an unknown certificate issuer for more
>than one time, it's not possible to input anything at the 2nd prompt (first
>prompt works as expected).
>
>I checked out "subversion" itself through https:// as explained in the FAQ -
>but I didn't yet manage to install the certificate (is there docs how to do
>this actually - I couldn't find anything helpful - would appreciate a tip for
>that).
>
>Here is what I type into the command prompt of my Windows 2000 box:
>(the current working dir is the root of the checked out sources)
>
>E:\Projects\svndev>svn update
>Error validating server certificate: Unknown certificate issuer. Accept?
>(y/N):
>y
>Error validating server certificate: Unknown certificate issuer. Accept?
>(y/N):
>svn: RA layer request failed
>svn: GET of /repos/svn/!svn/ver/5939/trunk/build.conf: Certificate
>verification
>failed (https://svn.collab.net)
>
>
>I peeked into the source code and _believe_ it's caused by the following
>code in
>subversion/clients/cmdline/prompt.c - Funktion svn_cl__prompt_user
>
> while (1)
> {
> status = apr_file_getc (&c, fp);
> if (status && ! APR_STATUS_IS_EOF(status))
> return svn_error_create (status, NULL, "error reading stdin.");
> if ((c == '\n') || (c == '\r'))
> break;
>
> svn_stringbuf_appendbytes (strbuf, &c, 1);
> }
>
>It breaks out of the loop on a \n or \r - but Windows uses \r\n as
>end-of-line so there
>could be an \n left from the first prompt.
>

Didn't we have a patch for that filed somewhere? I seem to remember
something like that, but I couldn't test the patch at the time because
the Windows build was broken. Does anyone remember where that patch
might be?

>
>Unfortunately, I've not yet set up a build environment to verify this.
>
>
>In case of any questions feel free ask! I'm happy to assist.
>
>(by mail, I'm not (yet) subsribed to the mailing list)
>
>best regards
>
>Werner
>
>
>

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 16 22:13:38 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.