Re: [patch] ask for username if getting UID fails

SteveKing wrote:

>Branko Čibej wrote:
>
>
>
>>>If by some weird offchance it ever does
>>>happen, there's no reason Subversion should take responsibility for
>>>reporting it to the user.
>>>
>>>
>>>
>>Why not?
>>
>>
>
>because it doesn't prevent subversion from doing it's job.
>Subversion simply can get the required information another
>way (ask for it).
>
[snip]

>>>getpwuid() of the result could fail. That's an error, but not a
>>>terribly serious one. Again, there's no reason Subversion shouldn't
>>>fall back to asking for a username in this case; we are a version
>>>control system, not a system diagnostic tool.
>>>
>>>
>>>
>>Again, why not? We report network errors instead of trying to reconnect.
>>It's not Subversion's job to try to recover from system errors.
>>
>>
>>
>
>Network errors are a little bit different. They occur while a subversion
>command is in progress, and there's no other way to do the command.
>For example you can't ask the _user_ to transport the data over the network.
>
>but for a simple UID you _can_ ask the user instead.
>That's the difference.
>
>

O.K., I give in. Now, is there any chance we could give the user a hint
about _why_ we're asking for the username? svn_handle_warning, or something?

-- 
Brane ÄŒibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org