[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Reduce memory usage of svn log -v

From: D.J. Heap <dj_at_shadyvale.net>
Date: 2003-05-15 04:37:33 CEST

Scott Collins wrote:
> I'm not sure I understand pools well enough either, however, I'm willing
> to put my money where my mouth is and test it. So I guess I'm not
> really evaluating your patch, so much as asking further questions of the
> person who eventually does.
> In your patch, would it be as effective to not add |scratchpool|, but in
> the place where you added |svn_pool_clear (scratchpool);|, substitute
> |svn_pool_clear (subpool);|? But if turns out you must add
> |scratchpool|, is it better if it comes out of |subpool| rather than
> |pool|?
> I'll go try in my working copy now.
> __________
> Scott Collins <http://ScottCollins.net/>

I believe subpool must not be cleared (actually I tried it and boom)
because the hash iterator is in it?

As far as making scratchpool come from subpool, I have no idea if that
would be better or not...I would be interested in a comment on that as well.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 15 04:38:28 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.