[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5929 - trunk/subversion/libsvn_wc

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-05-14 05:16:20 CEST

Greg Stein <gstein@lyra.org> writes:

> On Tue, May 13, 2003 at 08:28:07PM -0500, sussman@tigris.org wrote:
> >...
> > @@ -776,6 +763,14 @@
> > (SVN_ERR_WC_OBSTRUCTED_UPDATE, NULL,
> > "failed to add dir '%s': \nobject of the same name is already "
> > "scheduled for addition", path);
> > +
> > + /* Immediately create an entry for the new directory in the parent.
> > + Note that the parent must already be either added or opened, and
> > + thus it's in an 'incomplete' state just like the new dir. */
> > + tmp_entry.kind = svn_node_dir;
> > + SVN_ERR (svn_wc__entry_modify (adm_access, db->name, &tmp_entry,
> > + SVN_WC__ENTRY_MODIFY_KIND,
> > + TRUE /* immediate write */, pool));
>
> Don't you want to set the 'incomplete' flag here?
>
> Oh. This is in the parent dir, huh? The incomplete flag is only mentioned in
> THIS_DIR ?

Yup. Our universal rule of entries files is: a parent directory's
pointer to a subdir is nothing but a name, a file-kind, and possibly a
schedule flag.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 14 05:17:42 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.