[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1295 (take 2, with log)

From: Mark Grosberg <mark_at_nolab.conman.org>
Date: 2003-05-09 19:49:08 CEST

On 9 May 2003 kfogel@collab.net wrote:

> Mark, just a quick sanity check:
> If someone removes the line that says
> "--This line, and those below, will be ignored--"
> then all the files will be committed as usual, right? That's my


> understanding from reading the code in process_comitted_list (er,
> which I guess should be called `process_committed_list')... but I'm
> asking just to be sure.

> Conversely, what are the ways someone could get a target eliminated
> from the commit?:
> a) Remove that item's line from the msg?


> b) Change the modification letter code at the start of its line?

No. In this case, it would error out. I did that on purpose because I
wanted to make it rather fool-proof.

I can fix the spelling things and do take 5, should I?

> (And Brane already pointed out the problems with the 'silent return'
> mode when it encounters a letter code it doesn't expect.)

Take 4 does not have this problem.

> Of course, one way to answer my user interface questions is to supply
> the documentation patches with the code patches :-). Changes to the
> .xml files in doc/book/book/ are welcome.

After the patch goes in to the code I'll do the doc updates as a second
pass. Is that okay?

Mark G.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 9 19:51:11 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.