Re: [PATCH] Issue #1295

Mark Grosberg wrote:

>On 8 May 2003 cmpilato@collab.net wrote:
>
>
>
>>>+ /* I couldn't find an apr_array_delete -- MYG. */
>>>+ if (ci->nelts > 1)
>>>+ ci->elts[i] = ci->elts[ci->nelts - 1];
>>>+ ci->nelts--;
>>>+ }
>>>+ }
>>>+
>>>
>>>
>>I think I'd feel better about seeing this as a memmove().
>>
>>
>
>The memmove would be slower but it would keep the order. That's why I did
>this before the sort, so I could use the more efficient trick.
>
>If you want, I'll happily change it to a memmove(). Whatever you guys
>want...
>
No, just let the qsort do the job, like I suggested, and truncate the
array afterwards.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org