Re: [rfc/patch] Fix issue 734, import should 'mkdir -p'

David Kimdon <dwhedon@debian.org> writes:

> Hi,
>
> Here's a fix that I'd like another set of eyes on. It passes 'make
> check', of course. I'm not entirely sure that I'm doing the right
> thing closing the directory batons while I'm doing the mkdir's. I'm
> keeping just the last one, and the root baton open and closing the
> intermediate batons.

Unfortunately, that's not quite right. The rules of editor driving
require that you keep all the intermediate directories open, closing
them only as come back from the recursion on your way to closing the
root baton. A simply apr_array_header_t * of dir_batons should do the
trick for you. As an example, I did something very similar when I wrote
libsvn_client/copy.c:repos_to_repos_copy().

But thanks for working on this!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 2 14:48:10 2003