[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1075

From: <cmpilato_at_collab.net>
Date: 2003-04-28 19:48:27 CEST

Brian Denny <brian@briandenny.net> writes:

> On Mon, Apr 28, 2003 at 10:51:33AM -0500, cmpilato@collab.net wrote:
> >
> > My only concern is how svn_wc__do_update_cleanup() plugs into
> > svn_wc_add(). If I understand the code correctly, your new goodness
> > will get called any time svn_wc_add is called on a directory with
> > copyfrom args. I don't think we want that behavior at all.
> am i correct in thinking that the use case that would trigger this
> codepath is if you do an 'svn cp' on a directory that contains a
> missing directory?

I believe that's right.

> what is correct behavior in that case? the missing directory is also
> missing in the copy?

In theory, there's nothing inherently wrong with copying a missing
directory. In practice, it's likely to be buggy (just as, for
example, trying to commit the addition of a new, but missing,
directory). I wouldn't try to address those bugs as part of Issue
#1015, though.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 28 19:52:37 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.