[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: #774: [PATCH] avoid early exit when acting on some non-versioned files

From: <kfogel_at_collab.net>
Date: 2003-04-27 01:52:22 CEST

Eric Gillespie <epg@pretzelnet.org> writes:
> Resolve #774 ([PATCH] avoid early exit when acting on some
> non-versioned files).
>
> * subversion/clients/cmdline/main.c:
>
> (svn_cl__cmd_table): Add -q option to proplist and revert.
>
> * subversion/clients/cmdline/proplist-cmd.c:
>
> (svn_cl__proplist): Instead of using SVN_ERR, just store the err and
> check to see if it is SVN_ERR_ENTRY_NOT_FOUND. If it is, ignore the
> error and stop processing this file, printing a warning if the -q
> option was not used. For all other errors return the err object and
> let normal error processing occur.

The only comment I have (aside from "Yay, thanks for fixing this!") is
that if code is going to depend on certain error codes being returned
from svn_client_revert(), then svn_client_revert's doc string needs to
explicitly say that that error will be returned in that circumstance.

The same is true for svn_client_update() and svn_client_proplist(),
but I didn't look at them to see whether they already doc it.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 27 02:38:35 2003

This is an archived mail posted to the Subversion Dev mailing list.