Re: Did this slip through the net?

On Tue, Apr 15, 2003 at 08:21:49PM +0100, Philip Martin wrote:
> Hello
>
> The log for 5387 contains
>
> (do_single_file_merge): discover mimetypes in the two fetched
> proplists, pass them to merge_file_changed.
>
> but the code (libsvn_client/diff.c:1065) then and now does
>
> /* Discover any svn:mime-type values in the proplists */
> pval = apr_hash_get (props1, SVN_PROP_MIME_TYPE, strlen(SVN_PROP_MIME_TYPE));
> mimetype1 = pval ? pval->data : NULL;
>
> pval = apr_hash_get (props2, SVN_PROP_MIME_TYPE, strlen(SVN_PROP_MIME_TYPE));
> mimetype2 = pval ? pval->data : NULL;

Not to mention that those lines should use APR_HASH_KEY_STRING.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org