[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Compressed streams (take infinity)

From: Sir Woody Hackswell <woody_at_hackswell.com>
Date: 2003-04-01 14:05:45 CEST

On Mon, 31 Mar 2003, Greg Stein wrote:

> On Tue, Apr 01, 2003 at 01:29:42AM +0100, Philip Martin wrote:
> > Eric Dorland <eric.dorland@mail.mcgill.ca> writes:
> >...
> > > It's probably
> > > not worth it though. But hey, if it gets my patch in, I'll do it :)
> >
> > I'm not trying to be awkward, I'm just trying to understand the patch
> > without going to the trouble of reading the zlib documentation.
> How about a slight change in approach here?
> * is the concept useful and applicable? do we really want this feature?
> * is the current code "close enough"? can the tweaks be made to the code
> after it has been applied?
> My concern here is that if we ask patch submitters to tweak a nit here, and
> tweak a nit there, each coming in at different times as different reviewers
> find time to look at the code, that eventually the submitter will just throw
> their hands up in the air and go away.
> Now, I'm not saying "apply bad patches and fix them later." But I am saying,
> "can we alter the buffer size after the code is in?" or "can the data
> generation occur after the code is in?" It would seem that neither of those
> is fundamental to having the code added such that people can begin to
> exercise it in new ways.

I know it doesn't mean anything coming from me, but +1 this. ;)

Eric has been very very willing to learn the Subversion coding style and
learn how to make good patches. I wish everyone were as patient as he.
Obviously, Eric hasn't learned Hubris yet. ;] (Which is a good thing)

On the other hand, I agree with Greg that nitpicking a patch to death might
turn off some new developers.

-Richard Balint

      "Many waters cannot quench Love. / Rivers cannot wash it away.
       If one were to give all the wealth / Of his house for Love,
       It would be utterly scorned." (Song of Songs 8:7)

Sir.Woody_at_Hackswell.com http://sir.woody.hackswell.com

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 1 14:07:07 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.