[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Compressed streams (take 2)

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-04-01 04:58:50 CEST

On Tue, Apr 01, 2003 at 01:29:42AM +0100, Philip Martin wrote:
> Eric Dorland <eric.dorland@mail.mcgill.ca> writes:
>...
> > It's probably
> > not worth it though. But hey, if it gets my patch in, I'll do it :)
>
> I'm not trying to be awkward, I'm just trying to understand the patch
> without going to the trouble of reading the zlib documentation.

How about a slight change in approach here?

* is the concept useful and applicable? do we really want this feature?
* is the current code "close enough"? can the tweaks be made to the code
  after it has been applied?

My concern here is that if we ask patch submitters to tweak a nit here, and
tweak a nit there, each coming in at different times as different reviewers
find time to look at the code, that eventually the submitter will just throw
their hands up in the air and go away.

Now, I'm not saying "apply bad patches and fix them later." But I am saying,
"can we alter the buffer size after the code is in?" or "can the data
generation occur after the code is in?" It would seem that neither of those
is fundamental to having the code added such that people can begin to
exercise it in new ways.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 1 04:55:54 2003

This is an archived mail posted to the Subversion Dev mailing list.