Re: [PATCH] MIME type guessing improved for *nix systems

In message <864r5m2ia2.fsf@kepler.ch.collab.net>
          Ben Collins-Sussman <sussman@collab.net> wrote:

[snip]
> Yes, it's an excellent feature, but I'm unhappy with the
> implementation. I know there was a long discussion thread about this,
> but I don't remember the outcome or consensus... what was it?
>
> I really dislike having OS-specific code in Subversion. That's the
> reason we have APR. Can't we make APR do mime-type detection? The
> Unix implementation would look for mime.types, and the Win32
> implementation could consult the registry (or however it's done.)

Without wishing to appear confrontational I made no secret of the fact that
I was going to do this work and that this is the way I was going to do it.
Couldn't you have mentioned your concerns then?

My understanding of the consensus among those who expressed an oppinion
boils down to:

* It can take a long time to get things into APR
* APR is designed for a specific purpose so things we want may not be
  appropriate for inclusion.
* If the APR people want to take OS specific code we write on-board then
  they are welcome to.

-- 
(\/)atthew )-(ambley ---------------\ If something's worth doing it's worth
E-mail : matthew@aether.demon.co.uk  \ doing badly until you can learn to
Public key : C991137B                 \ do it well.
Web : http://www.aether.demon.co.uk/   \-----------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org