Re: [PATCH] Issue #1108

 
Karl,

thanks for the review!

> <giggle> I think you went a little board with the all-caps :-)
>
> "ALLOCATE" ?

heehee. that was a TYPO. or maybe a BRAINO. :-)
 
 
> Greg Stein just pointed out the line.find("SUBSTRING") idiom, which I
> didn't know about either, but would be appropriate here.

will do.
 

> Quick sanity check: you made sure the new regression test not only
> succeeds with the patch, but fails without it?

i did so for switch_tests.py... but now that you mention it,
i should probably do the same for target-test.

-brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 29 07:00:27 2003