[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1108

From: Brian Denny <brian_at_briandenny.net>
Date: 2003-03-29 06:45:08 CET

On Fri, Mar 28, 2003 at 10:52:03PM -0600, kfogel@collab.net wrote:
[snip]
> Btw, Brian, when I wrote:
>
> > The new doc string implies that it is an error to mix URLs and
> > non-URLs (as it probably should be). But I didn't see anything that
> > checks for this case in the new code?
>
> I don't remember why I thought it should be an error to mix URLs and
> non-URLs. It doesn't seem like such a problem now. Did you intend
> them to be mixable?

[thinking out loud]
well, if you mix URLs and non-URLs, you are pretty much guaranteed that
they won't have a common prefix. but i guess a caller might not care,
in which case it should be perfectly fine.

> In any case, either the doc string or the code would need to change.

let me make sure the code does something reasonable if you mix them,
and if so i'll add a test and change the docstring.

-brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 29 06:52:12 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.