Re: svn commit: rev 5449 - trunk/subversion/tests/clients/cmdline

Philip Martin <philip@codematters.co.uk> writes:

> Matt Kraai <kraai@alumni.cmu.edu> writes:
>
> > > Again, please please please write more than "fixed issue N". Now I
> > > have to go look up this issue in the database to even know what it's
> > > about. :-) A single sentence would suffice:
> > >
> > > "Fix issue #1193: don't use os.path.join in python tests"
> >
> > The next lines were
> >
> > * subversion/tests/clients/cmdline/basic_tests.py
> > (basic_checkout, basic_switch, basic_checkout_deleted): Use string
> > concatenation instead of os.path.join to construct URLs.
>
> That doesn't tell me that issue 1193 has anything to do with
> os.path.join. You may have changed the code to use os.path.join as
> part of some larger issue, or you may simply have fixed it in passing
> to make it consistent with the rest of the testsuite.

Yes. There are basically 3 depth levels that (I suspect) most people
have when reading a commit mail:

  1. look for a sentence or paragraph that explains what the change is
     about.

  2. if still interested, read about the symbols changed.

  3. if still interested, read the diffs.

It's important for people to be able to "bail out" after the first
depth level, so it needs to exist. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 25 20:21:12 2003