Re: [PATCH] Simple user-logging for svnserve daemon mode

Sir Woody Hackswell wrote:

>+ user = (char *) malloc(16 * sizeof(char));
>+
>

don't do that.

we use memory pools, not malloc, unless the malloc is necessary to
interoperate with another library (neon or berkeley db come to mind).
also, what's with the hard coded 16? and is user even freed anywhere?

as for the actual functionality, i'll leave it to ghuson to comment, as
i think he's got plans for ra_svn's authentication.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 25 19:04:08 2003