Re: svn commit: rev 5444 - in trunk/subversion: libsvn_subr tests/libsvn_subr

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:

> dlr@tigris.org wrote:
...
> >New Revision: 5444
...
> >@@ -401,11 +514,12 @@
> > {
> > if (cfg)
> > {
> >- cfg_option_t *opt = find_option (cfg, section, option, NULL);
> >+ cfg_section_t *sec;
> >+ cfg_option_t *opt = find_option (cfg, section, option, &sec);
> > if (opt != NULL)
> >- make_string_from_option (valuep, cfg, opt);
> >+ make_string_from_option (valuep, cfg, sec, opt, NULL);
> > else
> >- *valuep = default_value; /* ### TODO: Expand default_value */
> >+ expand_option_value (cfg, sec, default_value, valuep, cfg->x_pool);
> >
>
> Hmm, this slipped through my review. Did you run the tests with this
> change?

I forgot to run the tests. I'd run them successfully before, but not
since my last round of changes. :-/

> Because, if find_option returns NULL and default_value doesn't get
> expanded, this last line sets valuep to NULL instead of
> default_value, thus causing all sorts of havoc.
>
> I'm fixing this now.

Thanks, I'll look over your changes.

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org