Re: svn commit: rev 5447 - trunk/subversion/libsvn_subr

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:

> cmpilato@tigris.org wrote:
...
> >--- trunk/subversion/libsvn_subr/config.c (original)
> >+++ trunk/subversion/libsvn_subr/config.c Mon Mar 24 18:27:53 2003
> >@@ -517,12 +517,20 @@
> > cfg_section_t *sec;
> > cfg_option_t *opt = find_option (cfg, section, option, &sec);
> > if (opt != NULL)
> >- make_string_from_option (valuep, cfg, sec, opt, NULL);
> >+ {
> >+ make_string_from_option (valuep, cfg, sec, opt, NULL);
> >+ }
> >
> Yuck.

...
> > else
> >- *valuep = default_value;
> >+ {
> >+ *valuep = default_value;
> >+ }
> >
>
> And yuck. Why add braces just because you can?

The existing style of that file doesn't use braces for single line
blocks. Mixing formatting change with code changes makes the diffs
more work to read than need be.

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org