[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5447 - trunk/subversion/libsvn_subr

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-03-25 02:08:04 CET

cmpilato@tigris.org wrote:

>Author: cmpilato
>Date: Mon Mar 24 18:27:53 2003
>New Revision: 5447
>
>Modified:
> trunk/subversion/libsvn_subr/config.c
>Log:
>* subversion/libsvn_subr/config.c
> (svn_config_get): Fallback to default value if the expansion finds
> nothing. This makes my 'svnadmin create' stop SEGFAULTing.
>
>
>Modified: trunk/subversion/libsvn_subr/config.c
>==============================================================================
>--- trunk/subversion/libsvn_subr/config.c (original)
>+++ trunk/subversion/libsvn_subr/config.c Mon Mar 24 18:27:53 2003
>@@ -517,12 +517,20 @@
> cfg_section_t *sec;
> cfg_option_t *opt = find_option (cfg, section, option, &sec);
> if (opt != NULL)
>- make_string_from_option (valuep, cfg, sec, opt, NULL);
>+ {
>+ make_string_from_option (valuep, cfg, sec, opt, NULL);
>+ }
>
Yuck.

> else
>- expand_option_value (cfg, sec, default_value, valuep, cfg->x_pool);
>+ {
>+ expand_option_value (cfg, sec, default_value, valuep, cfg->x_pool);
>+ if (! *valuep)
>+ *valuep = default_value;
>+ }
> }
> else
>- *valuep = default_value;
>+ {
>+ *valuep = default_value;
>+ }
>

And yuck. Why add braces just because you can?

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 25 02:08:39 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.