Re: svn commit: rev 5429 - trunk/subversion/include

On Sun, Mar 23, 2003 at 08:57:18PM +0100, Branko ??ibej wrote:
>...
> >+typedef svn_error_t *(*svn_repos_commit_callback_t) (
> >+ svn_revnum_t new_revision,
> >+ const char *date,
> >+ const char *author,
> >+ void *baton);
>
> Yes, it is a pattern used elsewhere, but the meaning is exactly the same
> -- and now the code is less readable. We also seem to be using the
> "(*funptr)(args)" syntax instead of the more natural "funcptr(args)" for
> calls through pointers to functions.

I disagree on both parts. I find the above declaration and the (*funptr)
usage to be more readable.

For example, when I see:

    notify_func(arg1, arg2, arg3)

it is hard to figure out whether notify_func() is a function or is a
variable pointing to a function.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org