Re: svn commit: rev 5429 - trunk/subversion/include

gstein@tigris.org wrote:

>* include/svn_repos.h:
> (svn_repos_commit_callback_t): turn the typedef into an explicit
> pointer to a function. (this is the pattern used elsewhere)
>
[snip]

>-typedef svn_error_t *svn_repos_commit_callback_t (svn_revnum_t new_revision,
>- const char *date,
>- const char *author,
>- void *baton);
>+typedef svn_error_t *(*svn_repos_commit_callback_t) (
>+ svn_revnum_t new_revision,
>+ const char *date,
>+ const char *author,
>+ void *baton);
>
>

Yes, it is a pattern used elsewhere, but the meaning is exactly the same
-- and now the code is less readable. We also seem to be using the
"(*funptr)(args)" syntax instead of the more natural "funcptr(args)" for
calls through pointers to functions.

I wonder how long it will take until people finally begin to grok ISO C
and stop using brain-dead K&R syntax? :-(

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org