[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5429 - trunk/subversion/include

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-03-22 02:36:43 CET

On Fri, Mar 21, 2003 at 03:51:09PM -0600, cmpilato@collab.net wrote:
> gstein@tigris.org writes:
>...
> > +++ trunk/subversion/include/svn_repos.h Fri Mar 21 15:23:15 2003
> > @@ -349,10 +349,11 @@
> > * the @a new_revision, @a date, and @a author of the commit, along with
> > * the @a baton closure.
> > */
> > -typedef svn_error_t *svn_repos_commit_callback_t (svn_revnum_t new_revision,
> > - const char *date,
> > - const char *author,
> > - void *baton);
> > +typedef svn_error_t *(*svn_repos_commit_callback_t) (
> > + svn_revnum_t new_revision,
> > + const char *date,
> > + const char *author,
> > + void *baton);
>
> Dude, even with your mods, this would fit in 79 columns.

Yah... I tested it and saw that it would fit but it just felt too close, so
I decided to wrap the thing. If it's easy to do, then I try to wrap to avoid
anything in cols 78..80 or thereabouts.

*shrug*

We do have precedent for wrapping (see the log message receiver in
svn_types.h), so I went with it.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 22 02:34:32 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.