Re: [PATCH] Segfault when comitting property changes on wc root

Philip Martin <philip@codematters.co.uk> writes:
> Revision 5407 introduced the problem. Now it obviously has a bug
> because it causes a core dump in some cases, but is the change
> otherwise sensible? If I read the documentation for the BASE_DIR
> argument to svn_cl__make_log_msg_baton it appears to be a directory in
> which to create temporary files. Is it sensible to use BASE_DIR to
> trim a committed item's path?
>
> Philip - not sure I want to "own" this one!

Thanks for the summary, that helped (me) tremendously.

I don't know if it's sensible to use BASE_DIR or not, haven't looked
closely at the question yet. It may become irrelevant if we do the
walk-up-to-find-working-copy-root plan, anyway.

Justin, three possibilities:

  1. We can revert 5407 right away, and release 0.20.1.

  2. We can apply Volodya's patch right away, and release 0.20.1.

  3. We can switch to the new find-the-working-copy-root plan right
     away, and release 0.20.1.

Do you have a preference?

It's quite fine to go with (1) or (2) for 0.20.1, and then do (3)
later, of course.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 21 18:19:09 2003