[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 639] - introduce svn_filesize_t

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-03-18 04:30:49 CET

- assert (this_chunk->offset <= *offset);
- *offset -= this_chunk->offset;
+ assert (this_chunk->offset <= rep_offset);
+ assert (rep_offset - this_chunk->offset < SVN_MAX_OBJECT_SIZE);
+ *chunk_offset = (apr_size_t) (rep_offset - this_chunk->offset);

Are both of these assertions checking things that can't happen even if
the fs is corrupt?

I didn't see any other potential problems in my read-through.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 18 04:32:13 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.