[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5340 - trunk/subversion/clients/cmdline

From: <cmpilato_at_collab.net>
Date: 2003-03-17 18:07:21 CET

Greg Stein <gstein@lyra.org> writes:

> On Fri, Mar 14, 2003 at 01:49:50PM -0600, cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Fri Mar 14 13:49:34 2003
> > New Revision: 5340
> >
> > Modified:
> > trunk/subversion/clients/cmdline/copy-cmd.c
> > trunk/subversion/clients/cmdline/delete-cmd.c
> > trunk/subversion/clients/cmdline/import-cmd.c
> > trunk/subversion/clients/cmdline/main.c
> > trunk/subversion/clients/cmdline/mkdir-cmd.c
> > trunk/subversion/clients/cmdline/move-cmd.c
> > Log:
> > * subversion/clients/cmdline/main.c
> > (main): No longer make the log message baton.
> >
> > These functions now make their own log message batons.
> >
> > * subversion/clients/cmdline/copy-cmd.c (svn_cl__copy)
> > * subversion/clients/cmdline/move-cmd.c (svn_cl__move)
> > * subversion/clients/cmdline/delete-cmd.c (svn_cl__delete)
> > * subversion/clients/cmdline/mkdir-cmd.c (svn_cl__mkdir)
> > * subversion/clients/cmdline/import-cmd.c (svn_cl__import)
>
> This log message doesn't explain *why* this change was made. It looks like
> it'll work just fine, but why change a single call to log baton creation
> into *five* calls?

Ah, yes, I should explain. (And I just added this to the log message
for revision 5340.)

   The log message baton creator does validation on (what is
   essentially) the contents of the file specified by the --file (-F)
   argument. It errors out if those contents contain a NULL
   character. But -F is used for other things, too, like 'svn
   propset', which should *allow* NULL-character-having property
   values. By moving the log message baton creation to only the
   subcommands that need a log message baton, *only* log messages (and
   not property values provided via -F) will suffer this validation.

In the future, we should probably consider making --file (-F)
*strictly* refer to commit log messages, and come up with a new option
for property value files, so that the following can be possible:

   svn propset http://server.com/repos/my-file \
      --file /path/to/commit-msg \
      --prop-file /path/to/thumbnail.png

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 17 18:09:56 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.