Re: [PATCH] Conform to O'Reilly style guide

On Fri, Mar 14, 2003 at 11:29:05AM -0700, Larry Shatzer wrote:
> On Fri, Mar 14, 2003 at 09:50:48AM -0800, Matt Kraai wrote:
> > On Fri, Mar 14, 2003 at 10:15:04AM -0700, Larry Shatzer wrote:
> > > At the top of the HACKING file it mentions the O'Reilly style guide to be
> > > followed. Below is a patch to correct a few spots it was not followed.
> > >
> > > Log Message: Fix a few typos according to the O'Reilly Style Guide.
> >
> > Thanks, applied in revision 5334.
> >
>
> I noticed you left off the fileserver to file server fix. Was this on purpose?

No, I applied the patch and didn't notice it, as it was the second
fix on the line.

> In any case, here that is again, in case, plus a few more (can not to cannot,
> file name as filename, and it's Emacs, not emacs, at least in the style guide).

Thanks, all but

> @@ -1355,7 +1355,7 @@
>
> <para>Now, if this were the end of the pool story, it would hardly
> have merited special attention. Fortunately, that's not the
> - case. Pools can not only be created; they can also be cleared
> + case. Pools cannot only be created; they can also be cleared
> and destroyed, using <function>apr_pool_clear()</function> and
> <function>apr_pool_destroy()</function> respectively. This
> gives developers the flexibility to allocate several&mdash;or

committed in revision 5336. This hunk seems to change the meaning
from

  You may do things with pools besides creation...

to

  You must do things with pools besides creation...

Matt

-- 
Oink!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org