Re: Subversion 0.19.1 released.

On Thu, Mar 13, 2003 at 12:36:23PM -0500, Greg Hudson wrote:
> On Thu, 2003-03-13 at 12:11, Philip Martin wrote:
> > Do we have any code that is not thread safe?
>
> Well, the one thread-safety issue I know about is the collection of
> filename and line number information for errors. But the worst that is
> likely to happen in this case is that an error gets the wrong file and
> line number information--hardly a catastrophe.
>
> Also, I couldn't verify that svn_pool_create(NULL) is a thread-safe
> operation; I'm not sure if the APR global pool is locked. (There's
> definitely a mutex field inside pool structures, but I'm not sure if the
> global pool has one.) We create a pool off of the global pool every
> time we create an error.

Right. And with Sander's comment about the global pool being safe...

There is *no* reason to assume that we are not thread safe.

It has been a while since I've looked for mutable globals, but that is
really the key. We definitely have constant globals, and I think that I've
trained people :-) into adding the 'const' on there. So we should be fine.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org