On Wed, Mar 12, 2003 at 07:28:29PM -0600, cmpilato@collab.net wrote:
> Karl Fogel <kfogel@newton.ch.collab.net> writes:
> > Greg Stein <gstein@lyra.org> writes:
> > > Can you start using the client to make these changes? Using the CGI script
> > > means that the hook script doesn't run, which means that the mailing list
> > > won't get notifications of the change.
> > >
> > > I'd even go so far as to state that the CGI should be removed.
> >
> > If the client method showed *diffs*, then yes. But right now, it just
> > shows the new propval in its entirety, and you can't tell what changed.
> >
> > I frankly find those mails useless. Does anyone find them useful?
>
> Unfortunately, I'm afraid Karl is right. The mails are useful in that
> some notification of an event occurs, but generally my memory isn't
> precise enough to recall the pre- version of the property value well
> enough to infer a diff.
"some notification of an event" ... that is a lot more than the CGI
provides. We at least *know* the log message was changed. And I've gone back
to previous commit emails to see what the change was. Not ideal, certainly.
I thought the original idea was that the previous content would be given to
the script on stdin, but that we just hadn't implemented that yet. We could
also provide the new content to the pre- hook in case it wanted to perform a
check on the contents before allowing it (e.g. validate the format/schema of
the property).
(a tempfile won't work since it has to have a unique name, and there is no
way to transmit that name to the post-change)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 14 04:34:34 2003