Re: svnserve and tunneling over ssh (Matt Kraai take notice)

On Tue, 2003-03-11 at 13:07, Greg Hudson wrote:
> I don't see any documented guarantees about child cleanup order.

Sander says he is documenting a LIFO (stack) ordering for cleanups in
apr_pools.h. So you can just move the process cleanup handler before
the file cleanup handlers. When you fix up the comment, you might want
to mention why the order is important.

> I wrote:
> >> (It also appears that the pipes aren't being
> >> closed in the child process before ssh is exec'd, which the child
> >> cleanup handlers were supposed to take care of; that needs more
> >> investigation.)

> I was confused when I wrote that, and I'm still confused.

Got it. ssh dups its stdin and stdout fds, causing me to see extra
entries for those fds in /proc/<pid>/fd. (There's no way to distinguish
the read and write ends of a pipe in that listing.) APR is doing its
job fine, and ssh doesn't have a copy of the write end of its own input
pipe. So, you can blissfully ignore this part of the problem.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 19:50:00 2003