[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnserve and tunneling over ssh (Matt Kraai take notice)

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-03-11 19:07:47 CET

On Tue, 2003-03-11 at 13:00, Matt Kraai wrote:
> I need to register the process cleanup before the file ones, so
> that it runs after them?

I don't see any documented guarantees about child cleanup order. (There
was a conversation about it earlier where people may have agreed in
principle on some ordering guarantees, but if they're not documented,
they're not really guarantees.) So, rather than piggy-backing on the
child cleanup handler registration, separately register a single parent
cleanup handler which closes both files and then cleans up the process.

I wrote:
>> (It also appears that the pipes aren't being
>> closed in the child process before ssh is exec'd, which the child
>> cleanup handlers were supposed to take care of; that needs more
>> investigation.)

I was confused when I wrote that, and I'm still confused. (We don't set
the child cleanup handlers until after the process is created, and you'd
expect APR to take care of closing the pipe() results before exec'ing
the child process.) It's most likely a pre-existing problem, and I'm
not sure it has any bearing on the user-visible problem. I'll continue
to look into it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 19:08:42 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.