[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: propedit on svn:mime-type

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-03-11 01:02:35 CET

Alex Waugh wrote:

>In message <1047303679.3e6c95ff2183b@www.xbc.nu>
> brane@xbc.nu wrote:
>
>
>
>>Quoting Alex Waugh <alex@alexwaugh.com>:
>>
>>
>>
>>
>>>- SVN_ERR (svn_io_set_file_executable (path, TRUE, TRUE, pool));
>>>+ {
>>>+ /* Since we only check if the property exists or not, force the
>>>+ property value to a specific value */
>>>+ new_value = svn_stringbuf_create_from_string (value, pool);
>>>+ svn_stringbuf_set (new_value, SVN_PROP_EXECUTABLE_VALUE);
>>>+ SVN_ERR (svn_io_set_file_executable (path, TRUE, TRUE, pool));
>>>+ }
>>>
>>>
>>How about just:
>>
>> value = SVN_PROP_EXECUTABLE_VALUE;
>>
>>You don't have to create a stringbuf just to change the prop value to a fixed
>>string, right? :-)
>>
>>
>
>You still need to create a svn_string though, as value is a const. I
>suppose you could have a third non-const value variable instead.
>
Oh yes, but that doesn't have to be allocated dynamically. :-) See my
commit.

>>I'll make that change and commit later today.
>>
>>
>
>I've updated the tests in the patch below, and thought I might as well
>make the other two changes at the same time. Don't worry if you've
>already done them though.
>
As you see, I already committed your patch. Could you update and then
post a new patch for just the tests? Thanks!

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 01:03:12 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.