[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: propedit on svn:mime-type

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-03-11 01:00:09 CET

Alex Waugh wrote:

>In message <3E6BBC52.2020205@xbc.nu>
> Branko Cibej <brane@xbc.nu> wrote:
>
>
>
>>It would be a lot better if you created this stringbuf only if you
>>actually know that you'll have to munge the value. Or at least, if the
>>property name is one of those we recognise. You could move this into
>>each of the "if (strcmp...)" bits. I know it means copying the
>>svn_stringbuf_create_from_string call six times, but it also means you
>>won't go copying values for those props that we don't care about.
>>
>>
>
>Good point. Updated patch below, more tests to follow later.
>
>
Thanks! Committed (with a few modifications) in revision 5268.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 01:00:48 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.