[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] MIME types, peer review

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2003-03-10 21:52:14 CET

Daniel Rall <dlr@finemaltcoding.com> writes:
> > Hummm. He explicitly explained why he did not mark with [PATCH]. If
> > you have reason to think marking it as patch nonetheless is the right
> > thing to do, you failed to explain those reasons.
>
> IMHO, it's more likely to get review if marked with PATCH...YMMV.

The main function of "[PATCH]" is to signal the patch manager and
others that this is something that needs to be tracked, because it
might want to go into Subversion. So if the submitter explicitly
chose not to do that, we shouldn't second guess.

Most people who do code review read every message, or at least see
every thread, and decide to review based mainly on time and interest,
anyway (I think).

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 10 22:29:25 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.