Re: [1165] strictness of svn_config to Python's ConfigParser API

Daniel Rall wrote:

>How strict should I be conforming svn_config to Python's ConfigParser
>API?
>
One note here: I'm not that much concerned about the API, I'm mainly
interested in the interpretation of the file contents.

>Some differences which I see in the current implementation as I
>write config-test.c:
>
>1) [DEFAULT] section isn't handled (should provide default values for
>all other sections)
>
IIRC, [DEFAULT] provides defaults for /vadiable expansions/ in other
sections, not just any old defaults. So this is contingent on variable
expansion.

The /defaults/ parameter to the ConfigParser constructor is something
else, and IMHO we don't need it.

>2) Variable substitution isn't handled (duh)
>
This pertains directly to file contents interpretation, so yes, I'd like
to see it in.

>3) __name__ option isn't handled (should default to the name of the
>section)
>
This is an API issue, again, and I we don't need it.

>#2 sees like the main target, but I was curious if I should bother
>implementing #1 and #3. It would allow us to just point to the
>ConfigParser documentation for our interface contract, but would also
>result in a slightly more complex implementation.
>
>http://subversion.tigris.org/issues/show_bug.cgi?id=1165
>
>
I'd say just go with #2, and the appropriate handling of the [DEFAULT]
section for variable expansion. Again: [DEFAULT] does not provide
default values for any option, only for variable expansion if the
placeholder name is not found in the current section.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org