Re: [PATCH] make mod_dav_svn leak a little less

Greg Stein writes:
> >
> > Hmm, is the signature of dav_svn_getetag cast in stone?
>
> Right. The ideal is that more mod_dav hooks get a pool passed to them.
>
> The signatures are not set in stone, but changing them requires versioning
> the interface. That might not be so pleasant, but is doable.
>

This occurred to me this morning as I was in the shower:

const char * dav_svn__getetag_internal (const dav_resource *,
                                        apr_pool_t *pool);

const char * dav_svn_getetag(const dav_resource *resource)
{
        return dav_svn__getetag_internal(resource, resource->pool);
}

dav_svn_insert_prop would then call
dav_svn__getetag_internal(resource, resource->info->pool), and the
official API could stay the same. Of course, this kind of wrapping
is horrible, but it's the best I can come up with before my morning
coffee ;-)

Robert

-- 
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org