[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] make mod_dav_svn leak a little less

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-02-28 00:33:24 CET

On Thu, Feb 27, 2003 at 06:40:51PM +0100, Robert Pluim wrote:
> Justin Erenkrantz writes:
> > --On Thursday, February 27, 2003 6:04 PM +0100 Robert Pluim
> > <rpluim@bigfoot.com> wrote:
> >
> > > - return apr_psprintf(resource->pool, "\"%" SVN_REVNUM_T_FMT "/%s\"",
> > > + return apr_psprintf(p, "\"%" SVN_REVNUM_T_FMT "/%s\"",
> > > created_rev,
> > > - apr_xml_quote_string(resource->pool,
> > > + apr_xml_quote_string(p,
> > > resource->info->repos_path, 1));
> >
> > This may be bogus because resource->info->pool may be cleaned up
> > before the response is written. The test suite has no coverage
> > over any of the lifetime issues and probably wouldn't check the
> > ETag value for corruption. -- justin

bleh :-(

> The case that was causing the problem was when dav_svn_insert_prop
> calls dav_svn_getetag, since that causes temporary stuff to be
> allocated out of the response pool rather than the subpool in
> resource->info->pool. In this particular case, the return value of
> dav_svn_getetag is copied into the response pool, so I think it's ok
> here. I can't speak to the other cases until I find them :-)
>
> Hmm, is the signature of dav_svn_getetag cast in stone?

Right. The ideal is that more mod_dav hooks get a pool passed to them.

The signatures are not set in stone, but changing them requires versioning
the interface. That might not be so pleasant, but is doable.

If somebody wants to dig into creating a new API version for mod_dav, then
let me know, and we can start that discussion. The facilities are present,
so it is really a design discussion from there.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 28 00:28:41 2003

This is an archived mail posted to the Subversion Dev mailing list.