Re: svn commit: rev 5122 - in trunk/subversion: svnadmin include libsvn_fs tests tests/libsvn_fs

On Thu, Feb 27, 2003 at 12:01:20AM +0100, Branko Cibej wrote:
> cmpilato@collab.net wrote:
> >brane@tigris.org writes:
> >
> >>Author: brane
> >>Date: 2003-02-26 14:41:55 -0600 (Wed, 26 Feb 2003)
> >>New Revision: 5122
> >>
> >>Modified:
> >> trunk/subversion/include/svn_fs.h
> >> trunk/subversion/libsvn_fs/fs.c
> >> trunk/subversion/svnadmin/main.c
> >> trunk/subversion/tests/fs-helpers.c
> >> trunk/subversion/tests/libsvn_fs/fs-test.c
> >>Log:
> >>Use #defined constants instead of hard-coded strings for the FS config stuff.
> >>
> >>* subversion/include/svn_fs.h (SVN_FS_CONFIG_BDB_TXN_NOSYNC,
> >>SVN_FS_CONFIG_BDB_TXN_NOSYNC_LEN): New constants.
> >
> >SVN_FS_CONFIG_BDB_TXN_NOSYNC_LEN is unnecessary; just an extra thing to
> >maintain. Just use (sizeof (SVN_FS_CONFIG_BDB_TXN_NOSYNC) - 1) for
> >compile-time goodness.
>
> That seems quite obscure to me. I'd rather have APR calculate the key
> length.

Then *please* use APR_HASH_KEY_STRING instead.

Since this is very far from performance intensive, then there really isn't a
rationale reason to have a separate constant here...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org