[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5122 - in trunk/subversion: svnadmin include libsvn_fs tests tests/libsvn_fs

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-02-27 00:01:20 CET

cmpilato@collab.net wrote:

>brane@tigris.org writes:
>
>
>
>>Author: brane
>>Date: 2003-02-26 14:41:55 -0600 (Wed, 26 Feb 2003)
>>New Revision: 5122
>>
>>Modified:
>> trunk/subversion/include/svn_fs.h
>> trunk/subversion/libsvn_fs/fs.c
>> trunk/subversion/svnadmin/main.c
>> trunk/subversion/tests/fs-helpers.c
>> trunk/subversion/tests/libsvn_fs/fs-test.c
>>Log:
>>Use #defined constants instead of hard-coded strings for the FS config stuff.
>>
>>* subversion/include/svn_fs.h (SVN_FS_CONFIG_BDB_TXN_NOSYNC,
>>SVN_FS_CONFIG_BDB_TXN_NOSYNC_LEN): New constants.
>>
>>
>
>SVN_FS_CONFIG_BDB_TXN_NOSYNC_LEN is unnecessary; just an extra thing to
>maintain. Just use (sizeof (SVN_FS_CONFIG_BDB_TXN_NOSYNC) - 1) for
>compile-time goodness.
>
>
That seems quite obscure to me. I'd rather have APR calculate the key
length.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 27 00:02:08 2003

This is an archived mail posted to the Subversion Dev mailing list.